attestantio / dirk

Apache License 2.0
75 stars 22 forks source link

Dirk doesn't have an explicit case for handling the asm confidant #23

Closed MoustacheFarmer closed 2 years ago

MoustacheFarmer commented 2 years ago

Dirk supports asm through majordomo, but as it is currently Dirk doesn't have an explicit case for creating the asm confidant. Vouch does support the asm confidant and this particular snippet of code is missing in Dirk's initMajorDomo.

Dirk's initMajordomo: https://github.com/attestantio/dirk/blob/9428ecf22d6b6bfe53298ba12ef62c6b91c18631/main.go#L498-L541 Vouch's initMajordomo: https://github.com/attestantio/vouch/blob/5384df6f7a4911267885c7c12d8a4c3bdeb4e5a2/main.go#L538-L599