attestantio / dirk

Apache License 2.0
81 stars 23 forks source link

Add possibility to load credentials automatically for majordomo asm/gsm #29

Closed ghost closed 1 year ago

ghost commented 1 year ago

Google Cloud and AWS both support to load credential via metadata service without any interaction if IAM roles/sa are attached to VM.

Current it's impossible to use because dirk pass only credentialPath, and majordomo strictly use only that too (gsm, asm). I think it could be a good idea to make the default way getting credentials from metadata service work

selfuryon commented 1 year ago

It turns out that ASM support that right now due to non-mandatory path config option, which passed like empty string "", and GSM was fixed by https://github.com/attestantio/dirk/pull/31, so I close this issue