search

attestantio / go-eth2-client

Apache License 2.0
102 stars 59 forks source link

Pass `CommonOpts` downstream in `Validators` #102

Closed moshe-blox closed 5 months ago

moshe-blox commented 5 months ago

For your consideration. Personally I'm not sure if this is right, perhaps we do prefer to fallback to default timeout when deviating from the user's call? (Validators -> BeaconState)

mcdee commented 5 months ago

I have spent some time considering, and I think that it's valid to pass this along.

(At some stage we will be able to revert to using the validators endpoint, but that requires that endpoint to provide SSZ encoding, which is something I'm on the hook for. It's on the list.)