search

attestantio / go-eth2-client

Apache License 2.0
102 stars 59 forks source link

feat: UniversalProposal for produceBlockV3 #109

Closed pinebit closed 3 months ago

pinebit commented 4 months ago

This introduces UniversalProposal to support produceBlockV3 endpoint.

When I created the PR, I realized there is another one for the same purpose: https://github.com/attestantio/go-eth2-client/pull/107 done by @y0sher just a couple days ago.

In my implementation I did not deprecate the v2 endpoints, I believe they may co-exist safely in go-eth2-client project.

If you want to proceed with the other implementation, that's fine, just leave a note in the comment so I can close the PR.

cc @mcdee

mcdee commented 4 months ago

Hi thanks for the PR. Internally we have been working on unifying the underlying blinded and non-blinded proposal flows, and have an alternate pr #116

Please could you take a look at this and let me know if it meets your requirements? Thank you.

pinebit commented 4 months ago

Please could you take a look at this and let me know if it meets your requirements? Thank you.

Thank you @mcdee ! I quickly checked the changes, it will certainly cause bunch of changes on our side, because of the breaking changes. If you are certain about these changes will go master soon or late, then I can start migrating our code on this week.

pinebit commented 3 months ago

Closed in favor of @mcdee 's implementation.