`VersionedSignedProposal.assertMessagePresent()` does not check phase0 or altair

attestantio / go-eth2-client

Apache License 2.0

112 stars 65 forks source link

Closed pinebit closed 6 months ago

pinebit commented 6 months ago

We believe this function https://github.com/attestantio/go-eth2-client/blob/5a33417f219e12762e182e3844efd521299f4d5a/api/versionedsignedproposal.go#L248C10-L248C55 shall allow phase0 and altair messages. Right now this returns ErrUnsupportedVersion for such proposals, which seems wrong.

cc @mcdee

pinebit commented 6 months ago

Discussed offline.