search

attestantio / vouch

Apache License 2.0
112 stars 28 forks source link

Fix dirk default timeout bug #130

Closed dB2510 closed 1 year ago

dB2510 commented 1 year ago

This PR fixes dirk default timeout bug. It used to set default timeout of 30s for dirk account manager irrespective of the provided account manager. This led to vouch expecting dirk account manager in startAccountManager function even if wallet account manager is provided. Refer: https://github.com/attestantio/vouch/blob/2bbfe67138f56b45beb6bdd5219caa833316e4f7/main.go#L233 https://github.com/attestantio/vouch/blob/2bbfe67138f56b45beb6bdd5219caa833316e4f7/main.go#L931

mcdee commented 1 year ago

Thank you for reporting this issue. I'd rather not split out the defaults, and so have taken a different approach to this issue in #131 which should also be more robust in terms of deciding when to start which account manager. Please could you take a look at this and let me know if you are happy with that alternative patch?

dB2510 commented 1 year ago

Hey @mcdee

131 looks good to me. Closing this one in the favour of #131.

Thanks!