search

attic-labs / noms

The versioned, forkable, syncable database
Apache License 2.0
7.44k stars 266 forks source link

Remove httptest.serve flag spam #1629

Open kalman opened 8 years ago

kalman commented 8 years ago

Every noms command refers to httptest.serve flag which doesn't do anything. It comes from our d.Chk library including github.com/stretchr/testify/assert, which has a file http_assertions.go, which imports net/http/httptest, which has the flag.

A super easy way to fix this would be to fork testify then remove http_assertions.go and the HTTP related methods in assertion_forward.go.

Thoughts? @willhite @aboodman

aboodman commented 8 years ago

Lgtm

On Tuesday, May 24, 2016, Ben Kalman notifications@github.com wrote:

Every noms command refers to httptest.serve flag which doesn't do anything. It comes from our d.Chk library including github.com/stretchr/testify/assert, which has a file http_assertions.go, which imports net/http/httptest, which has the flag.

A super easy way to fix this would be to fork testify then remove http_assertions.go and the HTTP related methods in assertion_forward.go.

Thoughts? @willhite https://github.com/willhite @aboodman https://github.com/aboodman

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/attic-labs/noms/issues/1629

a (phone)