search

attic-labs / noms

The versioned, forkable, syncable database
Apache License 2.0
7.44k stars 266 forks source link

Consider using log.Printf rather than fmt.Printf for verbose messages #3590

Open ehalpern opened 7 years ago

ehalpern commented 7 years ago

Noms code uses fmt.Printf (by way of verbose.Log) to print notable events.

Unfortunately, this makes it difficult for a program that embeds noms to control how these messages are logged.

Using log.Printf rather than fmt.Printf routes the message through the go standard logger which solves this problem.

ehalpern commented 7 years ago

cc: @rafael-atticlabs, @cmasone-attic

cmasone-attic commented 7 years ago

I vaguely remember wanting to do that, but we didn't for some reason. Can't remember if it was some actual concern or just a "eh, we have no reason to change and we're already doing the other..." On Fri, Jul 14, 2017 at 5:24 PM Eric Halpern notifications@github.com wrote:

cc: @rafael-atticlabs https://github.com/rafael-atticlabs, @cmasone-attic https://github.com/cmasone-attic

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/attic-labs/noms/issues/3590#issuecomment-315495939, or mute the thread https://github.com/notifications/unsubscribe-auth/AMnImpcj9pfpZlw1DyVbuasTEFx7rdOpks5sOAbSgaJpZM4OY3FW .