attic-labs / noms

The versioned, forkable, syncable database
Apache License 2.0
7.44k stars 266 forks source link

NBS: Fix large HTTP {get,has}Refs/ requests #3629

Closed cmasone-attic closed 7 years ago

cmasone-attic commented 7 years ago

When we added GetMany and HasMany, we didn't realize that requests could then be larger than the allowable HTTP form size. This patch makes the body of getRefs and hasRefs be serialized as binary instead, which addresses this issue and actually makes the request body more compact.

Fixes #3589

cmasone-attic commented 7 years ago

PTAL