search

attic-labs / noms

The versioned, forkable, syncable database
Apache License 2.0
7.45k stars 266 forks source link

Unskip Perf Suite TestRunFlag #3646

Open arv opened 7 years ago

arv commented 7 years ago

This test is currently skipped

https://github.com/attic-labs/noms/blob/master/go/perf/suite/suite_test.go#L282

We found that it is writing to the wrong ValueReadWriter

cc @rafael-atticlabs @kalman

ghost commented 7 years ago

Note that adding some debug suggested that values are being written to one ValueStore and then referenced by another ValueStore during commit (go boom!). This is usually the result of a bad concurrency usage of Databases. I suspect the Spec stuff, but it's a bit hard to tell.

arv commented 7 years ago

The following tests are now disabled:

TestSuiteWithMem TestPrefixFlag TestRunFlag

The all show the same symptons