search

attic-labs / noms

The versioned, forkable, syncable database
Apache License 2.0
7.44k stars 266 forks source link

Use stretchr/testify not attic-labs/testify #3677

Closed kalman closed 7 years ago

kalman commented 7 years ago

stretchr has fixed a bug with the -count flag. I could merge these changes into attic-labs, but it's easier to just use strechr.

We forked stretchr a long time ago so that we didn't link in the HTTP testing libraries into the noms binaries (because we were using d.Chk in production code). The HTTP issue doesn't seem to happen anymore, even though we're still using d.Chk.

kalman commented 7 years ago

CC @arv but might as well TBR this once Jenkins is happy

kalman commented 7 years ago

jenkins: test this

kalman commented 7 years ago

:-\

kalman commented 7 years ago

Well, this passes, which was basically the point of this patch:

go test ./cmd/... ./go/... ./samples/... ./tools/... -count 2
arv commented 7 years ago

LGTM