search

attic-labs / noms

The versioned, forkable, syncable database
Apache License 2.0
7.45k stars 266 forks source link

remove no-longer-needed extraneous subdirs #3687

Closed wardn closed 6 years ago

arv commented 6 years ago

Thanks for the PR.

Can this wait? I have a huge patch in progress which touches a lot of files. It would be better to do the reorg when we do not have large patches in flight.

cmasone-attic commented 6 years ago

Was there an issue filed to do this cleanup? I'm not against deleting the JS stuff if it's no longer in use, but moving almost every file doesn't seem important right now On Sat, Sep 9, 2017 at 2:21 PM Erik Arvidsson notifications@github.com wrote:

Thanks for the PR.

Can this wait? I have a huge patch in progress which touches a lot of files. It would be better to do the reorg when we do not have large patches in flight.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/attic-labs/noms/pull/3687#issuecomment-328304240, or mute the thread https://github.com/notifications/unsubscribe-auth/AMnImmfJR_X9voxhQItiWeGMNoOOhPnNks5sgwFngaJpZM4PRypi .

aboodman commented 6 years ago

@cmasone-attic yes there was, it me: #3668.

Thanks @wardn for the patch. I'm in favor of this. The useless /go subdir has been bugging me for awhile.

aboodman commented 6 years ago

PS @wardn in order to accept any patch from you we'll need you to complete the contributor agreement first: https://github.com/attic-labs/noms/blob/master/CONTRIBUTING.md#contributing-code

wardn commented 6 years ago

fixed merge conflicts