search

attic-labs / noms

The versioned, forkable, syncable database
Apache License 2.0
7.45k stars 266 forks source link

NOMSFS: ensure clean path parsing #3696

Closed wardn closed 6 years ago

aboodman commented 6 years ago

If you closed this PR because of the test failure, it's not necessary to do that ... you can just upload a new patch and it will re run the tests.

On Tue, Sep 12, 2017 at 10:40 AM, wardn notifications@github.com wrote:

Closed #3696 https://github.com/attic-labs/noms/pull/3696.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/attic-labs/noms/pull/3696#event-1245773635, or mute the thread https://github.com/notifications/unsubscribe-auth/AAE6BAEk56PUdYCrJ0pjx1G8m4p9pHKLks5shsH2gaJpZM4PVAIG .

wardn commented 6 years ago

Found a few other spots for path cleaning in nomsfs and I didn't want to split it across multiple commits, I'll reopen it when it's all updated.

aboodman commented 6 years ago

OK. You can still re-use the same PR (just rebase locally and push --force when you upload your PR). It's a little less confusing than PRs showing up then disappearing a second later, then reappearing elsewhere.

Looking forward to the change!

On Tue, Sep 12, 2017 at 10:44 AM, wardn notifications@github.com wrote:

Found a few other spots for path cleaning in nomsfs and I didn't want to split it across multiple commits, I'll reopen it when it's all updated.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/attic-labs/noms/pull/3696#issuecomment-328929287, or mute the thread https://github.com/notifications/unsubscribe-auth/AAE6BGLbmtDkP4oiB-r-HdwLF4y6kNWKks5shsLxgaJpZM4PVAIG .

wardn commented 6 years ago

Agreed :] Sorry about the confusion.

wardn commented 6 years ago

Looks like they patched the workaround here... https://github.com/isaacs/github/issues/361 I may need to open another pull request unless you know of another way?

aboodman commented 6 years ago

Ah, go ahead and open a new one then :)

On Tue, Sep 12, 2017 at 11:06 AM, wardn notifications@github.com wrote:

Looks like they patched the workaround here... isaacs/github#361 https://github.com/isaacs/github/issues/361 I may need to open another pull request unless you know of another way?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/attic-labs/noms/pull/3696#issuecomment-328935410, or mute the thread https://github.com/notifications/unsubscribe-auth/AAE6BMhXg8J6Qb8TjqrS_JLfepYd9kIXks5shsgkgaJpZM4PVAIG .