search

attic-labs / noms

The versioned, forkable, syncable database
Apache License 2.0
7.45k stars 266 forks source link

IPFS deps are being linked into all noms clients #3709

Closed ghost closed 6 years ago

ghost commented 6 years ago 
Rafaels-MacBook-Pro-2:csv-export rafael$ git reset --hard 1a7e006862eb1e16cfd9901f0c6b0204100b09a1
HEAD is now at 1a7e0068 Landing beginning of IPFS experiment on trunk (#3625)
Rafaels-MacBook-Pro-2:csv-export rafael$ go build
Rafaels-MacBook-Pro-2:csv-export rafael$ ls -la csv-export 
-rwxr-xr-x  1 rafael  staff  33759076 Sep 15 05:36 csv-export
Rafaels-MacBook-Pro-2:csv-export rafael$ git reset --hard 8b5cd66cceb8d1204dd55b428c36b108e779b93e
HEAD is now at 8b5cd66c NBS: Expose hashes request builder for use in tests (#3630)
Rafaels-MacBook-Pro-2:csv-export rafael$ go build
Rafaels-MacBook-Pro-2:csv-export rafael$ ls -la csv-export 
-rwxr-xr-x  1 rafael  staff  12743332 Sep 15 05:37 csv-export

e.g. nearly tripped the size of the csv-export binary

kalman commented 6 years ago

I presume this is for spec parsing, and I'm not sure you can do much about that:

https://github.com/attic-labs/noms/blob/1e6a54d89f91061690ce6d5c153cdf69db72176f/go/spec/spec.go#L185

@willhite @arv mentioned something in slack about this a while back too

willhite commented 6 years ago

We could add some api that allowed clients to add protocols dynamically and we could use that for our IPFS chat application. The nice thing is that noms and all of other utils/samples would be unencumbered by IPFS libraries, the downside is that they wouldn't work with IPFS-based databases. :-(

aboodman commented 6 years ago

I think it is fine to make it pluggable. Just somebody needs to design the contract with spec package.

On Thu, Sep 21, 2017 at 8:14 PM, Dan Willhite notifications@github.com wrote:

We could add some api that allowed clients to add protocols dynamically and we could use that for our IPFS chat application. The nice thing is that noms and all of other utils/samples would be unencumbered by IPFS libraries, the downside is that they wouldn't work with IPFS-based databases. :-(

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/attic-labs/noms/issues/3709#issuecomment-331339233, or mute the thread https://github.com/notifications/unsubscribe-auth/AAE6BIt08orsaDjmJfBbgaVqLnXce8Prks5skyYrgaJpZM4PY6cR .