search

attic-labs / noms

The versioned, forkable, syncable database
Apache License 2.0
7.45k stars 267 forks source link

Update code blocks to always specify syntax, fix ordered list #3734

Closed jesseditson closed 6 years ago

jesseditson commented 6 years ago

General cleanup to finish up the last bit of formatting on https://github.com/attic-labs/decent-website/issues/13

jesseditson commented 6 years ago

Intentionally outdented the code there because it seems like showdownjs doesn't support indented code blocks - I could preprocess the blocks (I currently do that but I don't like it), but my preference is to just use formatting it can handle. What do you think?

phritz commented 6 years ago

Sgtm

On Sep 22, 2017 10:47 AM, "Jesse Ditson" notifications@github.com wrote:

Intentionally outdented the code there because it seems like showdownjs doesn't support indented code blocks - I could preprocess the blocks (I currently do that but I don't like it), but my preference is to just use formatting it can handle. What do you think?

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/attic-labs/noms/pull/3734#issuecomment-331556526, or mute the thread https://github.com/notifications/unsubscribe-auth/AAJl4bZlgt22By6g3lrx5LT155g3xT2gks5slBzEgaJpZM4PgGT3 .

phritz commented 6 years ago

That is, outdenting is fine.

On Sep 22, 2017 11:43 AM, fritz@atticlabs.io wrote:

Sgtm

On Sep 22, 2017 10:47 AM, "Jesse Ditson" notifications@github.com wrote:

Intentionally outdented the code there because it seems like showdownjs doesn't support indented code blocks - I could preprocess the blocks (I currently do that but I don't like it), but my preference is to just use formatting it can handle. What do you think?

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/attic-labs/noms/pull/3734#issuecomment-331556526, or mute the thread https://github.com/notifications/unsubscribe-auth/AAJl4bZlgt22By6g3lrx5LT155g3xT2gks5slBzEgaJpZM4PgGT3 .