Replace regexp with loop for struct name/field validation

attic-labs / noms

The versioned, forkable, syncable database

Apache License 2.0

7.45k stars 267 forks source link

Replace regexp with loop for struct name/field validation #3736

Closed arv closed 6 years ago

arv commented 6 years ago

Fixes #2866

ghost commented 6 years ago

LGTM. Can you verify that this at least didn't regress perf? Try profiling a noms serve and then write to it (e.g. with csv-import). This verification path should be invoked then.

arv commented 6 years ago

Verified. It showed up before and doesn't show up any more.

ghost commented 6 years ago

Nice.