attic-labs / noms

The versioned, forkable, syncable database
Apache License 2.0
7.45k stars 267 forks source link

Investigate better code sharing between valueDecoder and refWalker #3757

Open cmasone-attic opened 6 years ago

cmasone-attic commented 6 years ago

There's some duplication right now, because these are performance-sensitive code pathways and avoiding the allocations that valueDecoder needs is a meaningful performance gain when one is just walking refs.

Still, it smells like there's a better approach here. We need to try some ideas and see if any will work while causing only small performance degradations.

FYI @arv @rafael-atticlabs