search

attic-labs / noms

The versioned, forkable, syncable database
Apache License 2.0
7.45k stars 267 forks source link

Make compression a concern of noms (move out of individual chunk stores) #3771

Closed ghost closed 1 year ago

ghost commented 6 years ago

Given that nbs chunking is now doing predictive chunk sizing based on snappy, it makes more sense that this is a concern of noms.

cmasone-attic commented 6 years ago

YOu also have a compile failure at block_store_test.go:110. It's just another usage of NewChunk. I can't leave a comment there

atticlabs-ci commented 6 years ago

Build triggered. sha1 is original commit.

atticlabs-ci commented 6 years ago

Build started sha1 is original commit.

atticlabs-ci commented 6 years ago

Build finished.