search

attic-labs / noms

The versioned, forkable, syncable database
Apache License 2.0
7.45k stars 267 forks source link

remove git link folder preventing submodule update #3784

Closed tobowers closed 6 years ago

tobowers commented 6 years ago

As mentioned in #3782, this folder makes it so you can't use noms in a vendor manager (at least deps, glide, and godeps). It's a simple fix ( read about it here: https://stackoverflow.com/questions/4185365/no-submodule-mapping-found-in-gitmodule-for-a-path-thats-not-a-submodule/13394710#13394710 ).

Hopefully we can get this one merged quickly?

arv commented 6 years ago

This probably needs to be upstreamed.

I'm looking for it in https://github.com/ipfs/go-ipfs but I cannot find it.

@willhite Maybe we just need to update our ipfs deps?

tobowers commented 6 years ago

well - you might need to update the deps, but I think you need to merge this too... it's a "special mode" 16000 folder in the git repo, but there is no .gitmodule file... so it's definitely "broken" (checkout the stack overflow link)

arv commented 6 years ago

I'm OK merging this as is if it unblocks you. The change will be clobbered if we update the deps again.

@tobowers I don't think you have signed the CLA. See https://github.com/attic-labs/noms/blob/master/CONTRIBUTING.md

podviaznikov commented 6 years ago

I had the same problem when tryings to use deps. Mentioned it before in the slack channel

aboodman commented 6 years ago

Closed in favor of #3794 since @tobowers doesn't have a CA on file.