search

attic-labs / noms

The versioned, forkable, syncable database
Apache License 2.0
7.45k stars 267 forks source link

Add a multi-stage-build dockerfile #3800

Closed coriolinus closed 6 years ago

coriolinus commented 6 years ago

This is substantially based on https://hub.docker.com/r/scjalliance/noms/ but has been updated in two ways:

  1. It uses a multi-stage build to substantially reduce the size of the resultant image. The naive build image clocks in at ~1gb; the output image here is ~30mb.
  2. It takes advantage of the fact that the build context is already present, so we can speed up the build process by simply copying the context instead of cloning the data again.

This is intended to be compatible with #3790, and does not address any of the issues mentioned there except simple creation of a dockerfile. If the source repository for that PR were publicly available, this PR would have targeted that branch instead of master.

aboodman commented 6 years ago

LGTM, thanks for the contribution. You need to sign a contributor agreement as detailed here in order to accept the patch: https://github.com/attic-labs/noms/blob/master/CONTRIBUTING.md#contributing-code

coriolinus commented 6 years ago

I signed one before submitting: corporate, for Oneiro.

On Sat, Mar 31, 2018 at 6:59 AM, Aaron Boodman notifications@github.com wrote:

LGTM, thanks for the contribution. You need to sign a contributor agreement as detailed here in order to accept the patch: https://github.com/attic-labs/noms/blob/master/CONTRIBUTING. md#contributing-code

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/attic-labs/noms/pull/3800#issuecomment-377666363, or mute the thread https://github.com/notifications/unsubscribe-auth/AHdeTtLeyyWCTvtdQ78DKkLlM26ODoceks5tjw0bgaJpZM4TAN6A .