search

attic-labs / noms

The versioned, forkable, syncable database
Apache License 2.0
7.45k stars 267 forks source link

Using Dockerhub as a basic CI #3810

Closed kav closed 5 years ago

kav commented 5 years ago

Regarding #3792 Wanted to start the discussion on picking the low hanging fruit here.

If we'd like to do that I'm happy to write the .travis.yml if someone can enable travis for the repo

Note: tests have two actual failures at this point so this will fail to build at dockerhub. Accepting this pull as is though will show that failures do get correctly reported in the badge so should perhaps proceed before fixing the two issues.

Even if we move to travis and don't use docker build as the script, which is also fine, it might be worth considering accepting this change so that we don't publish broken code to the latest tag on dockerhub.

aboodman commented 5 years ago

It'd be cool to test PRs. And it looks like Travis is free for open source projects.

Are there any downsides to using Travis that you know of? It's been awhile since I've had to think about it. If not, I'll set it up today/tonight.

I agree it still makes sense to land this for the reason you mention.

===

Side note: in order to land this, I need you to complete the contributors agreement: https://github.com/attic-labs/noms/blob/master/CONTRIBUTING.md#contributing-code

aboodman commented 5 years ago

PS: Thanks for the contributions!

kav commented 5 years ago

Signed the agreement while the fork was... forking... so I should be good there, will add the above changes and the .travis.yml shortly

kav commented 5 years ago

I've not used Travis a lot, been doing more with Drone lately, but Travis still seems pretty handy given the free for OSS and hosted nature of it all.

kav commented 5 years ago

Alright @aboodman, I think this is ready for merge. I also pulled samples out of the build image as their test dependencies weren't resolving and it's not really related to noms working.

I haven't tested Travis file. Not 100% sure how to do that without just installing it and pushing

aboodman commented 5 years ago

Nits PR here: https://github.com/attic-labs/noms/pull/3811/files