search

attic-labs / noms

The versioned, forkable, syncable database
Apache License 2.0
7.45k stars 267 forks source link

fix mapeditor bug #3872

Closed phritz closed 4 years ago

phritz commented 4 years ago

MapEditor was erroneously going to the underlying map if the edit value was nil. The edit value will be nil when it has been removed (and so we shouldn't go to the underlying map).

aboodman commented 4 years ago

Eep. It was the way this change makes it originally, then it was changed, here:

https://github.com/attic-labs/noms/pull/3557/files#diff-9eaeaf4074255abb6cfef108897c6261R163

... as part of introducing support for "nested" ediotrs (e.g., you can have a value in an editor itself be another editor).

Can you see if there was some reason to add this branch that is now broken (which apparently doesn't have a test) or if it was just a mistake to introduce it originally?

Thanks!