attickdoor / MOActionPlugin

Dalamud plugin to allow for macro-less use of mouseover actions.
GNU General Public License v3.0
50 stars 57 forks source link

Major bug: action stacks with base action being a role action are bled between all the jobs who can use that role actions #95

Closed Alluneve closed 8 months ago

Alluneve commented 10 months ago

Action stacks set with base action being a role action are bleeding between multiple jobs.

EG: if you set up a stack with rescue, Swiftcast as its base action for WHM, this stack will also show up as applicable stacks for AST, SCH and SGE and cause erratic behavior.

the following fix does a check on the fetching of the applicable actions from Stacks by making sure to only grab stacks for your current role.

this however makes it so non-evolved jobs do not share stacks with their evolved kin anymore. working on an extra fix for that

edit: I found this out because I forgot to set up a stack on rescue for SCH, and I just now noticed I forgot to set that stack up and yet I still had the functionality as if I had set it up.

Alluneve commented 10 months ago

The removal of generic action bleeding to fix the erratic behaviour with role actions meant that non-upgraded jobs like CNJ,.... also did not experience the action bleeding anymore, and thus couldn't benefit from the actions of the job.

fixing this meant that I needed to reference the directory of jobs and make sure that the parent job (either a self-reference or a reference to its baby class (WHM references CNJ)) is also an acceptable job to be to get it's stacks

Alluneve commented 8 months ago

repackaging this into one pull request