attickdoor / XIVComboPlugin

Plugin version of the icon replacement features in dalamud
GNU General Public License v3.0
184 stars 282 forks source link

[RDM] Endwalker change #105

Closed bantte closed 2 years ago

bantte commented 2 years ago

The melee combo doesn't allow you to use the finishing move unless you have 25 of each mana, even though it only requires 15 of each now.

Log1x commented 2 years ago

https://github.com/attickdoor/XIVComboPlugin/blob/d574ccab6c661a52275b40c48fd078d76c652cda/XIVComboPlugin/IconReplacer.cs#L963-L985 needs adjusted for reference

hellozhewang commented 2 years ago

Also don't forget about resolution after scorch combo. I don't have access to push PR, but I think it should look something like this:

            if (Configuration.ComboPresets.HasFlag(CustomComboPreset.RedMageVerprocCombo))
            {
                if (actionID == RDM.Verstone)
                {
                    if (level >= 80 && (lastMove == RDM.Verflare || lastMove == RDM.Verholy)) return RDM.Scorch;
                    if (level >= 90 && (lastMove == RDM.Scorch)) return RDM.Resolution;
                    UpdateBuffAddress();
                    if (SearchBuffArray(1235)) return RDM.Verstone;
                    if (level < 62) return RDM.Jolt;
                    return RDM.Jolt2;
                }
                if (actionID == RDM.Verfire)
                {
                    if (level >= 80 && (lastMove == RDM.Verflare || lastMove == RDM.Verholy)) return RDM.Scorch;
                    if (level >= 90 && (lastMove == RDM.Scorch)) return RDM.Resolution;
                    UpdateBuffAddress();
                    if (SearchBuffArray(1234)) return RDM.Verfire;
                    if (level < 62) return RDM.Jolt;
                    return RDM.Jolt2;
                }
            }
attickdoor commented 2 years ago

it's fixed.