Open lucyawrey opened 1 year ago
I included this PR in my fork. Absolutely love this version of the Samurai melee combos.
I would love for this to be merged into the main plugin, it's literally what I've wanted since I began playing XIV. In the meanwhile, I only use GitHub to report bugs so I have little to no idea how to make any of this work for myself. Might you assist me somehow?
What it does
This PR adds two new combos to XIV Combo. These are:
Reasoning
I use XIV Combo primarily to collapse combos without any branching paths or decision points into a single button.
For example, on GNB I use the Solid Barrel combo and the Demon Slaughter combo, as there are no branching paths. But on the Ninja, I only use the Aeolian Edge and Hakke Mujinsatsu combos, and leave Armor Crush as is. This is because it is a branching path for ending the Aeolian Edge combo.
On Samurai, I wanted to have Jinpu -> Gekko and Shifu -> Kasha collapsed into one button because I have already made the choice between which of the three Hakaze follow up combos I want to use. This saves on some button space but keeps the feeling and rhythm of Samurai's combo flow intact.
A huge bonus is not having duplicate icons on my hotbar anymore! I still save a few buttons but don't have to look at 4 Hakazes on my bar at once and not remember which button starts each combo, as each action only exists in one combo chain.
Conclusion
I have been using this modification on my own computer for months now but just now decided to create an actual git commit and PR as I would love if this feature could be in the main project.
Sorry for the really long explanation! I hope you'll consider my addition.