attickdoor / XIVComboPlugin

Plugin version of the icon replacement features in dalamud
GNU General Public License v3.0
177 stars 282 forks source link

Summoner Ruin/Outburst Combos #263

Open Binarynova opened 1 year ago

Binarynova commented 1 year ago

Per Tansoric's suggestion, this PR adds a new combo option for Summoner.

This makes:

A great perk of this, is that it makes Ruin act similarly for Ifrit/Garuda/Titan to the way it already does with Bahamut/Phoenix.

This took a bit more doing than I expected. Trying to simply replace Ruin with Gemshine resulted in Gemshine not changing to the attuned avatar's Ruin variant (similar issues with Tri-Disaster and Precious Brilliance). So I manually handle the level logic for all the swapping. Someone with more understanding of the base code might be able to do this more cleanly.

I've used this one quite a bit and think it might be ready to be merged. I haven't done a lot of pull requests before, so I'm open to conversations about process if I did something wrong. Thanks!