attickdoor / XIVComboPlugin

Plugin version of the icon replacement features in dalamud
GNU General Public License v3.0
177 stars 282 forks source link

Incompatible with Dalamud 9.5 #278

Closed GiacomoLaw closed 10 months ago

GiacomoLaw commented 10 months ago

Plugin shows as Outdated and cannot be enabled for Dalamud 9.5

DorkmasterFlek commented 10 months ago

Pull request #281 fixes this.

GiacomoLaw commented 10 months ago

Lovely work.

ExtraThicc1993 commented 10 months ago

For someone who doesn't really understand what this means (sorry for the stupid question): is this a fix or still being worked on? If it is, how do I apply it?

GiacomoLaw commented 10 months ago

@DorkmasterFlek has submitted a fix for it, but the main plugin has yet to be updated

DorkmasterFlek commented 10 months ago

Technically not me, I'm just linking the pull request and the issue. :stuck_out_tongue:

GiacomoLaw commented 10 months ago

Ah my bad, didn't read the author

Gigi8325 commented 10 months ago

As someone disabled who uses this plugin to alleviate pain from Rheumatoid Arthritis....please don't abandon. :) Your work is vital and amazing to me...

GiacomoLaw commented 10 months ago

As someone disabled who uses this plugin to alleviate pain from Rheumatoid Arthritis....please don't abandon. :) Your work is vital and amazing to me...

As we wait, take a look at this fork: https://github.com/Grammernatzi/XIVComboPlugin

Compatible with v9.

ExtraThicc1993 commented 10 months ago

To follow up on Gigi - is this plugin planned to be decommissioned by the author/taken over by someone else? there basically is no update or any communication so I am unsure if I will ever see this plugin again

GiacomoLaw commented 10 months ago

To follow up on Gigi - is this plugin planned to be decommissioned by the author/taken over by someone else? there basically is no update or any communication so I am unsure if I will ever see this plugin again

View the various forks here and you can see more updated and maintained version.

https://github.com/attickdoor/XIVComboPlugin/network

I would recommend the one I linked above, was updated before Dalamud private beta came out so seems very active.

Also see: https://github.com/attickdoor/XIVComboPlugin/issues/282#issuecomment-1750046600

People can't always instantly update plugins as life gets in the way.

MKhayle commented 10 months ago

attick has confirmed in private channels that he will be updating it, although it may take some time.

Krojack commented 10 months ago

I'm seeing 18 mins ago commits so looks like it's being updated. Just a matter of time before it's pushed out to Dalamud I guess.

Gigi8325 commented 10 months ago

I can't thank you enough for updating.... excellent work

GiacomoLaw commented 10 months ago

Closed in 64d14678443cd72e2baf62842114069730f63d8c