search

attickdoor / XIVComboPlugin

Plugin version of the icon replacement features in dalamud
GNU General Public License v3.0
177 stars 282 forks source link

Updated PLD and Sam to 7.0 #294

Open Icemasta opened 1 month ago

Icemasta commented 1 month ago

Those are the only ones I go to 100 that I can confirm, not sure if you want to do piecemeal PRs so other people can push the class they know. I'll try to do more a few more tomorrow based on patch notes.

SAM changes:

PLD changes:

-Requiescath becomes Imperator at level >= 96 -Imperator becomes Blade of Honour if the buff Blade of Honour Ready is up.

kcaseyrsui commented 1 month ago

can you add MCH pls.

Kumate1 commented 1 month ago

Just some random player but your addon is the only reason I play FFXIV because it made Paladin enjoyable and didn't force me to stare at my action bar. Right now I am really hurting not having Fast Blade, Riot blade, and royal authority combo. You say it is completed but is there a way I can update and install it? No joke I will donate $100 instantly if this is working so I can use it. I have extremely trials with my guild this upcoming Friday and am lost without it lol. Know that sounds horrible but with my hand injury, it really is a game changer for me.

Icemasta commented 1 month ago

@Kumate1 It depends entirely on how much knowledge you got about compiling. All donations should either go to charity or attickdoor.

The basics are installing visual studio 2022 with C# libraries. Then you would clone the version you want (https://github.com/Icemasta/XIVComboPlugin/tree/master until it is either merged or someone else's work gets merged), open up the SLN file using VS2022 and then compile. It's pretty straight forward. If that is out of your reach and you want to trust an external source, I can compile the DLL, it's like 10 seconds.

After that you'll need to add it in Dalamud as a dev plugin by going into experimental and adding the folder that contains the DLL and version jsons and enabling it.

Kumate1 commented 1 month ago

Ice, I would love the help. The first part sounds out my league but I think I could manage the second part. Will the new DLL conflict or mess up the original FFXIV combo plug in once it is updated? I was looking for a way to send you a private message but not seeing one

Icemasta commented 1 month ago

@Kumate1 As usual, use this at your own risk since you didn't compile it yourself, but here are the DLLs I compiled for this. No, it will not mess up FFXIV combo, since it only adds actions within what already existed.

Basically open dalamund settings, go to experimental tab, add the path where you unzipped the file and press the +, don't forget to click the save button! image

Then under the plugins, you'll see the released version and the dev version, make sure the dev version is enable and disable the live version for now. Once the real version is updated, just disable the dev version and remove the path in experimental and then enable the live version and that's it. image

Kumate1 commented 1 month ago

Your awesome Ice. Quick question, is there a way to force the current plugin to work even if its an old version? Its fully disabled for me right now and not sure if there is a way to bypass that I am missing.

But I will get this rolling today and update ya. Thanks!

Icemasta commented 1 month ago

Your awesome Ice. Quick question, is there a way to force the current plugin to work even if its an old version? Its fully disabled for me right now and not sure if there is a way to bypass that I am missing.

But I will get this rolling today and update ya. Thanks!

It isn't compatible at all with both the current version of FF or the current version of Dalamud.

Kumate1 commented 1 month ago

It worked, can't express how amazing this is. Please let me know who I can donate too or if I can help in anyway. Thanks so much

chase692 commented 1 month ago

are you going to be adding thje 2 new dps or there is no need to?

PlebusMaximus32 commented 1 month ago

Using a compiled verson to test samurai and samurai Kash Geeko and Yukikaze combo is broken after lvl 92 when you get goyfu it dosen't point to the next skill in any combo

Icemasta commented 1 month ago

Using a compiled verson to test samurai and samurai Kash Geeko and Yukikaze combo is broken after lvl 92 when you get goyfu it dosen't point to the next skill in any combo

Aw sorry that's my bad, I forgot about the lastMove update. I've updated it, here is the new compiled DLL if you wanna try out.

latest.zip

Also @eroptar did another SAM branch here https://github.com/attickdoor/XIVComboPlugin/pull/301

PlebusMaximus32 commented 1 month ago

Using a compiled verson to test samurai and samurai Kash Geeko and Yukikaze combo is broken after lvl 92 when you get goyfu it dosen't point to the next skill in any combo

Aw sorry that's my bad, I forgot about the lastMove update. I've updated it, here is the new compiled DLL if you wanna try out.

latest.zip

Also @eroptar did another SAM branch here #301

Can confirm your new DLL is working as intended thnx for the fix and feedback. i will probably check out the other branch after softball tonight or thursday

TripleShock commented 1 month ago

I'm a bit confused, I tried putting the path in, but it's not compiled like yours (so of course it doesn't work haha) I read through the thread and you tell Kumate1 that you've compiled it for them, and "here it is" but I don't see any link or file leading to the compiled version? I MUST be missing something here (I rarely use Github, didn't even realize I had this account lol) could you link me the download for the newest version, compiled please? c:

Icemasta commented 1 month ago

I'm a bit confused, I tried putting the path in, but it's not compiled like yours (so of course it doesn't work haha) I read through the thread and you tell Kumate1 that you've compiled it for them, and "here it is" but I don't see any link or file leading to the compiled version? I MUST be missing something here (I rarely use Github, didn't even realize I had this account lol) could you link me the download for the newest version, compiled please? c:

It's like 2 posts up here, latest.zip https://github.com/attickdoor/XIVComboPlugin/pull/294#issuecomment-2215769513

XIV-Paladin commented 1 month ago

@Icemasta I'm usually a lurker but I just made this account just to say thank you! This works perfectly for me.

IdriveaSubaru commented 1 month ago

Hello, I'm getting this issue right here about main UI callback, plugged in from the latest.zip. Not quite sure what I'm missing here. image

Or maybe bard / dnc in particular are not working currently? These're the jobs I was looking for it to be working with the xivcombo

Icemasta commented 1 month ago

Hello, I'm getting this issue right here about main UI callback, plugged in from the latest.zip. Not quite sure what I'm missing here. image

Or maybe bard / dnc in particular are not working currently? These're the jobs I was looking for it to be working with the xivcombo

This branch is only for fixed SAM and PLD, BRD and DNC aren't touched. That warning is just because there isn't an integration into the dalamud plugin platform to open /pcombo explicitely I believe, but it has no impact whatsoever.

attickdoor commented 1 month ago

Thank you for the contribution!

Icemasta commented 1 month ago

  • Zanshin change is not necessary, the game gives you the option to make that happen. I'm rejecting the other PR's Zanshin combo.

    • Remove the AST card thing for now, that will be addressed in some other commit.

Thank you for the contribution!

Updated, although someone did a bigger PR here that might just be a lot easier to work with for integration. https://github.com/attickdoor/XIVComboPlugin/pull/304