attickdoor / XIVComboPlugin

Plugin version of the icon replacement features in dalamud
GNU General Public License v3.0
178 stars 282 forks source link

VPR: Generational Legacy with new gauge enums #330

Closed Skooz closed 1 month ago

Skooz commented 1 month ago

I assume this is the implementation you were looking for. This works on staging, but I guess the only issue is the obvious ambiguity problem;

SerpentCombo is an ambiguous reference between Dalamud.Game.ClientState.JobGauge.Enums.SerpentCombo and FFXIVClientStructs.FFXIV.Client.Game.Gauge.SerpentCombo

So, it's not spiffy looking, but it works.

IIRC we could also handle Death Rattle & Last Lash this way, if we want to.