search

attickdoor / XIVComboPlugin

Plugin version of the icon replacement features in dalamud
GNU General Public License v3.0
178 stars 282 forks source link

Samurai Ikishoten #352

Open QuoteXV opened 3 weeks ago

QuoteXV commented 3 weeks ago

Does Ikishoten not turn into Ogi Namikiri and Kaeshi: Namikiri anymore?

mkirk413 commented 2 weeks ago

I noticed this today as well. This was working in Skooz'z fork.

mkirk413 commented 2 weeks ago

Actually, I played around with this a little bit more. Ikishoten grants BOTH Zanshin Ready and Ogi Namikiri Ready. Additionally, Zanshin and Ogi Namikiri do not share a cool down and SE made it so you can map Zanshin to Ikishoten. So from that stand point, you would have Ikishoten->Zanshin one one button and Ogi Namikiri->Kaeshi: Namikiri on another.

Edit to add TL:DR not broken

Skooz commented 2 weeks ago

It was removed because of Zanshin. Same deal for War's Inner Release and Primal Rend. Having the option interferes with player choice; the code would have to prioritize one ability over the other.

In most cases with XIVCombo, the code will choose the logical braindead choice, like the next step in a 123 combo.

However, there's no obvious choice between these two abilities; there is no intended sequence for them to be used in, other than looking up a rotation online. Thus, enabling the combo would hinder your flexibility while playing; if the combo prioritizes Zanshin, what do you do if you want to use Ogi Namikiri first? It could also be seen as rotation automation, as the code is technically making an intelligent decision for you, even if it's not a big one.

IMO it's not a big deal, since Shoha got condensed into one button; I just put Ogi where the AoE Shoha used to be.

mkirk413 commented 2 weeks ago

IMO it's not a big deal, since Shoha got condensed into one button; I just put Ogi where the AoE Shoha used to be.

This