search

attickdoor / XIVComboPlugin

Plugin version of the icon replacement features in dalamud
GNU General Public License v3.0
184 stars 282 forks source link

Does not work well in 4K. Too small to see, or crops vital information. #64

Closed lovelydumpling closed 3 years ago

lovelydumpling commented 3 years ago

In 4K, at default scale the plugins menu are too tiny to see.

https://i.imgur.com/86F1Vkj.jpg

Dalamud has a setting to scale up the UI up to 2x, but in doing so, not everything fits in XIVCombos's window. Text overlapps and is cut off the screen, and more detrimentally the Save buttons are cropped off the bottom of the window. Scrolling down to the bottom does not reveal them.

https://i.imgur.com/dWHUYga.jpg

Other plugins let you click and drag the bottom right corner to resize/shape the plugin window, which lets everything fit. But many, including this one, do not. It'd be really helpful if this feature was added.

attickdoor commented 3 years ago

Wild. For some reason I didn't realize it was fixed size. This'll be fixed come October.

lovelydumpling commented 3 years ago

(Is this fix still coming? It's still a fixed size as of the recent update.) Edit: To be clear I don't mean to rush you I'm sorry if it comes across like that. I just didn't know if it was supposed to be in that update or not.

Edit 2: Well, it's past October. I suppose then I'll be holding out for the Endwalker update then. If it's still broken by then, idk if I should make a new issue?

ryankhart commented 2 years ago

Ya, it's still an issue for me. I probably would have left the issue open so that people searching the issues with the default filters don't end up posting duplicate issues. IMO, the time to close an issue is when the fix is live and available to everyone.

I'm just happy that this issue will probably get addressed in the future, but I'm in no rush.

lovelydumpling commented 2 years ago

I'm sorry, yeah. I don't understand why this issue was closed, it is still a problem. The plugin has received several updates since then but this issue hasn't been fixed.

lovelydumpling commented 2 years ago

Wild. For some reason I didn't realize it was fixed size. This'll be fixed come October.

Please re-open this issue, it was never fixed

ryankhart commented 2 years ago

Another alternative that could solve this problem in this plugin as well as all the other plugins that have a problem when you scale the font size in the Dalamud settings is if Dalamud settings had a UI scale instead of a font scale, so every fixed window sized plugin would be scaled with the fonts