Closed vikasgarghb closed 9 years ago
Nice work here! All around this looks pretty good!
One thing I wanted to achieve in this implementation is inferring the parser by the file extension as well as what you've provided with the additional configuration option. I think the following would be an ideal solution:
.yml
, use yml
parser, otherwise default to JSONAnd lastly my nitpick would be to change the configuration key from configType
to parser
, so we would be using:
gulpNgConfig('module', {
parser: 'yml'
});
Thanks for taking a look, will make the required changes.
@ajwhite Pushed the requested changes.
@ajwhite Made the requested changes.
Nice work :) I'll notify you via this thread when the release goes out.
LGTM :+1:
https://github.com/ajwhite/gulp-ng-config/issues/19 @ajwhite Mind taking a look at this?