atticoos / gulp-ng-config

:wrench: Create AngularJS constants from a JSON config file
MIT License
173 stars 35 forks source link

Add YML support. #20

Closed vikasgarghb closed 9 years ago

vikasgarghb commented 9 years ago

https://github.com/ajwhite/gulp-ng-config/issues/19 @ajwhite Mind taking a look at this?

atticoos commented 9 years ago

Nice work here! All around this looks pretty good!

One thing I wanted to achieve in this implementation is inferring the parser by the file extension as well as what you've provided with the additional configuration option. I think the following would be an ideal solution:


And lastly my nitpick would be to change the configuration key from configType to parser, so we would be using:

gulpNgConfig('module', {
  parser: 'yml'
});
vikasgarghb commented 9 years ago

Thanks for taking a look, will make the required changes.

vikasgarghb commented 9 years ago

@ajwhite Pushed the requested changes.

vikasgarghb commented 9 years ago

@ajwhite Made the requested changes.

atticoos commented 9 years ago

Nice work :) I'll notify you via this thread when the release goes out.

LGTM :+1: