Fixed an issue where environment constants would prevent optional consta...

[danwkennedy]

...nts from getting written to the output file.

[atticoos]

Ty for fixing this oversight!

Closes https://github.com/ajwhite/gulp-ng-config/issues/21

[clabnet]

I'm not sure that working:

• on win 10, gulp-ng-config ver. 1.2.1, with this .json:

{
  "dev": {
    "EnvironmentConfig": {
      "api": "http://localhost/"
    }
  },
  "production": {
    "EnvironmentConfig": {
      "api": "https://api.production.com/"
    }
  }
}

• the Gulp task :

gulp.task('ngConfig', function () {
  return gulp.src(config.configJson)
    .pipe(gulpNgConfig('dcc.config'), {
      environment: 'production'
    })
    .pipe(gulp.dest(config.scripts))
});

• my expected result would be: (only one entry, related to "production" key)

angular.module('dcc.config', [])
.constant('production', {"EnvironmentConfig":{"api":"https://api.production.com/"}});

• and instead it is : (both entries)

angular.module('dcc.config', [])
.constant('dev', {"EnvironmentConfig":{"api":"http://localhost/"}})
.constant('production', {"EnvironmentConfig":{"api":"https://api.production.com/"}});

Maybe I did not understand how to use it?

Thank you, bye

[atticoos]

It looks like your gulpfile has an incorrect syntax:

.pipe(gulpNgConfig('dcc.config'), {
  environment: 'production'
})

You're passing the configuration as a second argument to pipe, rather than gulpNgConfig

You'll want to tweak it so it's passed to gulpNgConfig:

.pipe(gulpNgConfig('dcc.config', {
  environment: 'production'
}))

More details here

[clabnet]

You are right, it is my mistake. It run, grazie.

[atticoos]

:smile: :+1: