search

atticoos / gulp-ng-config

:wrench: Create AngularJS constants from a JSON config file
MIT License
173 stars 35 forks source link

Added 'pretty' option #27

Closed se-panfilov closed 9 years ago

se-panfilov commented 9 years ago

Added 'pretty' option for issue#26 ( https://github.com/ajwhite/gulp-ng-config/issues/26 ).

atticoos commented 9 years ago

Awesome contribution! And i actually didn't know that there's a third parameter for formatting the output, very cool.

se-panfilov commented 9 years ago

Updated. So, i'm added new tests, except the last one - which should test error handling (cause I'm haven't enough expirience)

se-panfilov commented 9 years ago

And I'm updated readme, but this is a draft, cause my bad language. You should improve it or replce with a normal readme

atticoos commented 9 years ago

Could you clean this up so that travis passes? Lot of code styles are failing. I'll merge once we get the green light and follow up with some general cleanup of the readme and the commented out test.

Make sure to run gulp test as outlined in the contributing section of the readme, that will identify the code style errors

se-panfilov commented 9 years ago

Done. But please keep in mind that there still no tests for error handling

atticoos commented 9 years ago

Thanks @se-panfilov! Will get this merged soon, just want to prep a branch so i can follow it up after this merges

atticoos commented 9 years ago

Hey @se-panfilov, was about to merge but saw there's a conflict. Likely the README file

se-panfilov commented 9 years ago

@ajwhite done

atticoos commented 9 years ago

Ty man, sorry for the delay!

se-panfilov commented 9 years ago

No problem. Just happy to be useful ))