search

atticoos / gulp-ng-config

:wrench: Create AngularJS constants from a JSON config file
MIT License
173 stars 35 forks source link

Change installation section #36

Closed dimitardanailov closed 9 years ago

dimitardanailov commented 9 years ago

It's much better to install gulp-ng-config in our package.json.

npm install gulp-ng-config is syntax for global installation.

atticoos commented 9 years ago

npm install gulp-ng-config is syntax for global installation.

I wouldn't say it's a global installation unless it has -g, but more so a local installation that won't be tracked & managed by the package file

dimitardanailov commented 9 years ago

@ajwhite Ok.

atticoos commented 9 years ago

I don't think you should necessarily dismiss it, just think we should use --save-dev if we're going to add it :+1:

dimitardanailov commented 9 years ago

--save-dev for me is not a good option.

Main purpose / goal of gulp-ng-config is too have different configuration for development and production environment.

For me correct flag should be: --save and need to add explanation, why plugin use --save flag.

What do you think ?

atticoos commented 9 years ago

I suppose that leaves us to a different interpretation of --save-dev. To me, devDependencies are dependencies that you use for your development and building of the project. Whereas regular dependences would be the actual node_modules that your application will use and require as part of the application codebase.

This is not a dependency, it's a devDependency for preparing and building the application. The application itself does not use this, therefor it is not a dependency. By counter logic, that would mean that gulp should also be your dependency and not a devDependency, as that leaes dependencies to be dependent on modules in devDependencies.

As their docs state

Install gulp in your project devDependencies

https://github.com/gulpjs/gulp/blob/master/docs/getting-started.md

dimitardanailov commented 9 years ago

Ok, I am agree with your comment. I have different point of view, but never mind.