Fix issue with linters that prefer single quotes

atticoos / gulp-ng-config

:wrench: Create AngularJS constants from a JSON config file

MIT License

173 stars 35 forks source link

Fix issue with linters that prefer single quotes #57

Open seyDoggy opened 8 years ago

seyDoggy commented 8 years ago

Activity: ajwhite/gulp-ng-config/issues/12

I ran into this issue as well where linters (Sonarlint in my case) take exception to the double-quotes output. I've changed the template and test files to use single-quotes and am using .replace on the template.constant.value to replace double-quotes with single-quotes.

Tests pass.

coveralls commented 8 years ago

Coverage remained the same at 100.0% when pulling 17490cb9037c4bf0d625d901d7f873468e074901 on seyDoggy:Values-of-constants-wrapped-in-double-quotes-breaks-JSHint into b6e1c45be74842fe405c6d05770520d484095e12 on ajwhite:develop.

coveralls commented 8 years ago

Coverage remained the same at 100.0% when pulling e0da517d1dd83bf7f621d61da7f8418acbc6a3de on seyDoggy:Values-of-constants-wrapped-in-double-quotes-breaks-JSHint into b6e1c45be74842fe405c6d05770520d484095e12 on ajwhite:develop.

coveralls commented 8 years ago

Coverage remained the same at 100.0% when pulling 88bd0104a0fd151a1ae314ab15a7efda5e1bb063 on seyDoggy:Values-of-constants-wrapped-in-double-quotes-breaks-JSHint into b6e1c45be74842fe405c6d05770520d484095e12 on ajwhite:develop.

seyDoggy commented 8 years ago

Fully tested, singleQuotes as a feature, let me know your thoughts.

coveralls commented 8 years ago

Coverage remained the same at 100.0% when pulling 8fc50737de43cd8e752a3af38acb704a37bc5b7a on seyDoggy:Values-of-constants-wrapped-in-double-quotes-breaks-JSHint into b6e1c45be74842fe405c6d05770520d484095e12 on ajwhite:develop.

seyDoggy commented 8 years ago

Any feedback?

uatuko commented 7 years ago

@ajwhite Any idea when this can get merged and released?