Open rpm23 opened 8 years ago
Totally agree, great call 😄
Any updates on this feature? heheh
Thanks a lot for your plugin! By the way there's a mistake in the documentation, the jQuery call should be .stockQuote() and not .stockQuotes() with the 's'
Hey @amichel86,
I would love to, but I need to seek contributions at the moment. Would you be interested?
By the way there's a mistake in the documentation, the jQuery call should be .stockQuote() and not .stockQuotes() with the 's'
I think it should work for either spelling!
Hey @ajwhite I tried the spelling in the doc and it wasn't working unfortunately, it caused a JS error. I think the /dist/ version is not up to date
For the contribution, how much do you need and when could I expect the feature to be released? I would need it for by the end of the week. Realistic?
Here's what I need for my project
Hey @amichel86 -- I should clarify, I meant I'm seeking a code contribution (pull request)! I am not seeking monetary contributions -- this is open source and free 😄
I just don't have time at the moment and would love someone to take a look if they could!
I do have some guidance for anyone interested in contributing a solution for this:
By introducing a second metric/value to display, if we keep things as they are today, we impose an arbitrary order of content on the user of the plugin. For instance: some people might want the price to come before the symbol, some might want it after.
As we introduce more information that can be displayed, I suggest allowing an opt-in configurable approach as follows:
<span class="stock-quote" data-symbol="TWTR">
<span data-symbol-value="price"></span> // shows the price
<span data-symbol-value="change"></span>// shows the change
// user can also put their own content in here as well
</span>
This is just a psuedo example to illustrate the overall ideal. The goal that should be achieved is to allow the user to specify where the pieces of data should be displayed
Progress towards this has been slated out for this evening, thanks to @amichel86 who has insisted on a monetary contribution ❤️
I really like your approach but it looks like there is no option to include the current price. Depending on the target audience, I think that's a feature most devs would find useful.