search

attify / firmware-analysis-toolkit

Toolkit to emulate firmware and analyse it for security vulnerabilities
MIT License
1.29k stars 251 forks source link

setup.sh: Consider not patching firmadyne to change interpreter which is standard already #81

Open ddorando opened 1 year ago

ddorando commented 1 year ago

https://github.com/attify/firmware-analysis-toolkit/blob/master/setup.sh#L36

Since python2 is EOL anyways (https://www.python.org/doc/sunset-python-2/), it may be worth considering removing this patch to sorta clean-up the firmadyne installation of non-upstream changes.

extremecoders-re commented 1 year ago

The patch is in place to support Ubuntu 18.04 which defaults to Python2 for the python command. 18.04 goes out of support on April and we should be good to remove the patch then. Besides explicitly referring to Python 3 doesn't harm IMO :)

ddorando commented 1 year ago

Yeah. This is either about removing a patch which isn't really needed after Ubuntu 18.04 goes EOL (and thus making it kinda redundant to leave it in), or keeping the explicitness that already is there. In case there isn't any OS that FAT should support supporting python 2 I'd personally suggest to remove it. Just to save a few lines of code and get that tiny bit closer to plain upstream firmadyne.

I know this isn't doing much of anything at this point right now, though IMHO we should keep as close to plain firmadyne as possible to avoid any possible confusion.