attilabuti / vscode-mjml

This repo is archived. MJML preview, lint, compile for Visual Studio Code.
https://marketplace.visualstudio.com/items?itemName=attilabuti.vscode-mjml
MIT License
144 stars 59 forks source link

Linting Error #32

Closed dnuanes closed 6 years ago

dnuanes commented 6 years ago

Pertains to latest version: 1.4

Linter is displaying error "Attribute line-height has invalid value: 1.2 for type Unit, only accepts (px, %) units and 1 value(s)" when error does not exist.

Sample occurrence: a line that has commented code i.e. having error message displayed. Sample occurrence has nothing to do an attribute of line-height.

When commented code is deleted and following line moved up, error is then displayed for that line, even though following line does not have line-height as an eligible attribute.

`

(error displayed on this line) `
michaelroper commented 6 years ago

@dnuanes - i was seeing similar behaviour, and figured out that it was related to errors in files that were being referenced by the mj-include tags. Eg, an error on line 3 in the included file was showing the linting error on line 3 in the main document, where it didn't make sense.

Not sure what the fix would be though..