attilabuti / vscode-mjml

This repo is archived. MJML preview, lint, compile for Visual Studio Code.
https://marketplace.visualstudio.com/items?itemName=attilabuti.vscode-mjml
MIT License
144 stars 57 forks source link

Screenshot problem #48

Open gil04 opened 5 years ago

gil04 commented 5 years ago

After updating to version 1.6.0 I have problems with the Screenshots.

E.g. the following template will result in a complete gray screenshot (default width is 650px):

<mjml>
  <mj-body background-color="gray">
    <mj-section>
      <mj-column>
        <mj-table>
          <tr>
            <td>&bull;</td>
            <td>Test - 1</td>
          </tr>
          <tr>
            <td>&bull;</td>
            <td>Test - 2</td>
          </tr>
        </mj-table>
      </mj-column>
    </mj-section>
  </mj-body>
</mjml>

test

When doing a multipel screenshot with 320/650/1024 only the 320er screenshot is empty. The 650 and 1024 screenshot contains data: test_650

Any idea what could be wrong here?

attilabuti commented 5 years ago

Hello @gil04,

Please use the issue template next time and provide all information asked in it.

What is your operating system? Which version of VSCode you are using? Can you send me your mjml.screenshot* configuration?

gil04 commented 5 years ago

Hello @attilabuti

sorry - didn't noticed the issue template.

My operation system is: macOS Mojave (10.14) VSCode Version: Version 1.28.2 (1.28.2)

And this is my screenshot config:

  "mjml.screenshotWidths": [
        320,
        650,
        1024
    ],
    "mjml.screenshotType": "png",
    "mjml.screenshotQuality": 85,

Thx!

attilabuti commented 5 years ago

@gil04 I will fix it in the next update.