Open pogojotz opened 4 years ago
Hi, ideally with proper async support you shouldn't have to call asyncio.sleep
ever so I'd not recommend this code in production.
Having some kind of AsyncDispatcher
would be nice, I haven't used the async lib enough myself to know if one can recognize whether an async function was passed to the dispatcher (in which case we could bundle the wait
call in it).
PRs are welcome if you find a cleaner version that doesn't involve hardcoded sleep calls :)
@pogojotz the changes merged in #173 released in 1.9.0 support async handlers that can return responses over the same socket.
But what about UDP handlers? The change affects only TCP as far as I can see.
You're right - I couldn't find a straightforward way to call Dispatcher.async_call_handlers_for_packet()
because it needs to be awaited and the protocol handler only defines a synchronous method for datagram_received
. It may be possible to call the async handler using loop.call_soon()
and then send the responses. I'll try to find some time to take a look at it.
I guess the appropriate course would be to change or even rewrite a lot of the current UDP handling code, to have an async pathway there too. But on a quick glance this looks like quite a chunk of work.
I was wondering if it is possible to map async coroutines in the dispatcher. I run the
AsyncIOOSCUDPServer
to integrate python-osc in my asyncio driven service, but if I map an async coroutine in the dispatcher I get something like "coroutine was never awaited" during runtime.As a workaround I use wrappers like:
Is this the way to go or a horrible example of bad code? Is async support planned for the dispatcher?
Thank you.