fix(gui): add support for checking if the cli is installed on windows

atuinsh / atuin

✨ Magical shell history

https://atuin.sh

MIT License

18.54k stars 519 forks source link

fix(gui): add support for checking if the cli is installed on windows #2162

Closed YummyOreo closed 1 week ago

YummyOreo commented 1 week ago

On windows, this makes the default shell powershell and adds support for checking if atuin is installed on windows in the gui

Checks

[x] I am happy for maintainers to push small adjustments to this PR, to speed up the review cycle
[x] I have checked that there are no existing pull requests for the same thing

CarterLi commented 3 days ago

Just find this in the changelog of the latest release. Does it mean that we now support Windows?

YummyOreo commented 3 days ago

Just find this in the changelog of the latest release. Does it mean that we now support Windows?

Tentatively. It builds, but there isnt a powershell plugin yet (but there is a nushell plugin) but iirc someone was working on that.

ellie commented 3 days ago

It will usually build and run on Windows thanks to @YummyOreo's work, but we don't really have the bandwidth (time, hardware, etc) to test and support it properly.

CarterLi commented 3 days ago

I'll have a try

CarterLi commented 3 days ago

It works!

CarterLi commented 3 days ago

This is a binary if someone doesn't want to built it himself. Don't know why it's so large though

atuin.zip