atuinsh / atuin

✨ Magical shell history
https://atuin.sh
MIT License
18.54k stars 520 forks source link

filter out various environment variables containing potential secrets #2174

Closed drmorr0 closed 1 week ago

drmorr0 commented 1 week ago

Add secret key filters for AWS_ACCESS_KEY_ID, AWS_SECRET_ACCESS_KEY, AZURE_STORAGE_ACCOUNT_KEY, and GOOGLE_SERVICE_ACCOUNT_KEY.

I don't know how common these environment variables are. I know there are a lot of libraries that look in AWS_ACCESS_KEY_ID and AWS_SECRET_ACCESS_KEY env vars for credentials, but I've done a bunch of searching and it seems like that pattern is less common for the other cloud providers?

Checks