atuinsh / atuin

✨ Magical shell history
https://atuin.sh
MIT License
18.54k stars 520 forks source link

feat: add user account verification #2190

Closed ellie closed 5 days ago

ellie commented 5 days ago

Add atuin account verify for verifying the user account email address

This is not required, and so far has no real benefit. It can be used in a follow up for resetting passwords.

We've used Postmark for the forum for a long while now, and I'm super happy with it. Verified emails is only really beneficial for Atuin Cloud, so I'm not currently considering a generic SMTP server approach. Happy to do so if people want it, but I'd rather not maintain something nobody is using.

Checks

tessus commented 4 days ago

I suspect that people who self-host the server would also want the option to reset passwords. And the ability for the servwr to send emails is a pre-req for that, isn't it?

But maybe I am wrong.

ellie commented 4 days ago

If they're hosting it themselves, it's possible without email infrastructure - which is frustrating to maintain, or costs money. From the last time I asked, most people host instances either just for themselves, or for a very small number of people.

I've had to reset maybe 20 accounts, out of about 10,000. It's unlikely most people self hosting will run into the same issues, and I've put this off for as long as possible. We're just now reaching numbers where it's required.

Again though, like my PR said; should anyone self hosting actually want this, then it's possible. If they're happy to use Postmark, then they can use this as-is. I'm just not at the point where I'm willing to write or maintain features that nobody actually requires or uses.

tessus commented 4 days ago

Personally I don't need it. But I have seen that people use applications in an interesting fashion. e.g. look at the vaultwarden project. It was supposed to be a bw compatible solution for "personal" use. However, people use it in companies for hundreds and thousands of users.

I can imagine that the people who use vw in that fashion would also use atuin the same way.

On the other side, who knows, maybe they just open a PR against atuin to add the option to specify an SMTP server.

My comment was rather meant to emphasize how popular atuin has become.