Why height 98% of .editor-container?

atularen / ngx-monaco-editor

Monaco Editor component for Angular 2 and Above

https://www.npmjs.com/package/ngx-monaco-editor

MIT License

428 stars 155 forks source link

Why height 98% of .editor-container? #142

Open Willyisback opened 5 years ago

Willyisback commented 5 years ago

Why is the height of css class .editor-container set to 98% and not to 100%?

To look up in ngx-monaco-editor/projects/editor/src/lib/editor.component.ts

I need 100%. So I must use ::ng-deep, which should not be used.

antonellopasella commented 4 years ago

I tried to force 100% by CSS but the editor area height keep growing in size. What is the pro of 98%?

Thanks!

ckrasi-old commented 4 years ago

I also noticed this and the pro is that it looks bad. Maybe not when it is 200px height, but having it at almost full screen height makes it having big empty space at the bottom. Also, I changed it to 100%, kept resizing window to and it looks good, no issues with growing in size. Maybe they've fixed something and now it behaves correctly.

abierbaum commented 2 years ago

I found that using height: calc(100% - 1px) seemed to work ok FWIW.