search

atularen / ngx-monaco-editor

Monaco Editor component for Angular 2 and Above
https://www.npmjs.com/package/ngx-monaco-editor
MIT License
428 stars 155 forks source link

Angular 10 Compatible Version #180

Open ori-sh opened 4 years ago

ori-sh commented 4 years ago

With version 9.0.0 of ngx-monaco-editor, Angular 9 and tslib 1.10 are peer dependencies. This makes the following warnings to appear when trying to use with Angular 10:

warning " > ngx-monaco-editor@9.0.0" has incorrect peer dependency "@angular/common@^9.0.0".
warning " > ngx-monaco-editor@9.0.0" has incorrect peer dependency "@angular/core@^9.0.0".
warning " > ngx-monaco-editor@9.0.0" has incorrect peer dependency "tslib@^1.10.0".

So far I didn't experience any bugs or problems with ngx-monaco-editor on Angular 10 so if no changes needed will be great to have a patch which changes the peer dependencies to something like this:

"@angular/common": "^9.0.0 || ^10.0.0"
"@angular/core": "^9.0.0 || ^10.0.0"
"tslib": "^1.10.0 || ^2.0.0"