atularen / ngx-monaco-editor

Monaco Editor component for Angular 2 and Above
https://www.npmjs.com/package/ngx-monaco-editor
MIT License
428 stars 155 forks source link

Support Latest Stable Angular version 13 #240

Open kishor-p opened 2 years ago

kishor-p commented 2 years ago

It appears that ngx-monaco-editor expects angular version to be 12.

Please bump up the version.

npm ERR! ERESOLVE unable to resolve dependency tree       
npm ERR!
npm ERR! While resolving: sample-project@0.0.0
npm ERR! Found: @angular/common@13.0.1
npm ERR! node_modules/@angular/common
npm ERR!   @angular/common@"~13.0.0" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer @angular/common@"^12.0.0" from ngx-monaco-editor@12.0.0
npm ERR! node_modules/ngx-monaco-editor
npm ERR!   ngx-monaco-editor@"*" from the root project
ufReitter commented 2 years ago

It seems to work fine after installed or updated with --force flag

miki995 commented 2 years ago

@here I've a new fork with latest angular 14, ngZone upgrade and fixed production missing assets, have a look, works for my company now:

https://www.npmjs.com/package/ngx-monaco-editor-v2