atularen / ngx-monaco-editor

Monaco Editor component for Angular 2 and Above
https://www.npmjs.com/package/ngx-monaco-editor
MIT License
428 stars 155 forks source link

Support last Monaco versions #243

Open MikaStark opened 2 years ago

MikaStark commented 2 years ago

Hello, For now, ngx-monaco-editor has a peer dependency to monaco version 0.24.0. But the last one is 0.31.1.

Please bump up the monaco peer dep version.

Anyway thanks for this superbe project :).

coloz commented 2 years ago

change the config to:

{ "glob": "*/", "input": "node_modules/monaco-editor/dev", "output": "assets/monaco" }

MikaStark commented 2 years ago

@coloz thanks for the answer but that's not the point, the dependency work very fine even using monaco version above 0.24 but the issue is that ngx-monaco-editor library has a peer dependency on monaco-editor ~0.24.0. It will be cool to unlock the version to allow the latest ones.

Until it's done, I use https://www.npmjs.com/package/@materia-ui/ngx-monaco-editor instead.