atuline / FastLED-Demos

Here's my updated FastLED demos from January, 2017.
GNU General Public License v3.0
611 stars 174 forks source link

pop #3

Open antonmeyer opened 9 years ago

antonmeyer commented 9 years ago

I think, that is not a perfect logic: if (ranamount >NUM_LEDS) ranamount = NUM_LEDS; // Make sure we're at least utilizing ALL the LED's. int idex = random16(0, ranamount);

if (idex < NUM_LEDS) {        

I have 180 LEDs. If ranamount is set to 50, I will see only a portion. From my perspective the idea of the parameter ranamount got a bit lost.

if you want idex < NUM_LEDS, why did´nt you call int idex = random16(0, ranamount -1); or if the idea of ranamount got lost: int idex = random16(0, NUM_LEDS -1);