search

atuline / WLED

Control WS2812B and many more types of digital RGB LEDs with an ESP32 over WiFi.
GNU General Public License v3.0
864 stars 132 forks source link

Random effect presets does not work #250

Closed dosipod closed 1 year ago

dosipod commented 1 year ago

What happened?

Random effect in a presets or playlist will not work : e.g {"seg":{"fx":"r"}} in a playlist will crash SRWLED13.3 and could result in issue with presets

Also non-existing effect number 169 as pointed by @softhack007 will loop the gui ( MCU was accessible after power cycle )

To Reproduce Bug

Use {"seg":{"fx":"r"}} in a preset and call that preset with a play list . you may also try {"seg":{"fx":169}} but this may brick the MCU ( It did not in our tests )

Expected Behavior

{"seg":{"fx":"r"}} will produce random effect without errors

Install Method

From https://wled-install.github.io/

What version of Soundreactive WLED?

WLED 0.13.3 (build 2210301)

Which microcontroller/board are you seeing the problem on?

ESP32

Relevant log/trace output

No response

Anything else?

No response

Code of Conduct

dosipod commented 1 year ago

We have tested WLED 0.13.3.3 (build 2211111) and {"seg":{"fx":"r"}} still does not work

softhack007 commented 1 year ago

Bug fixed, please try again with SR Build 2211172 or later.

dosipod commented 1 year ago

Issue seems to be resolved . We tested with 0.13.3.3 (build 2211183) , {"seg":{"fx":"r"}} in a playlists works as expected

softhack007 commented 1 year ago

Fix included in latest v0.13.4-beta release